Skip to content

Use default INDEX_URL from Settings to use environment variables #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

MarcelBochtler
Copy link
Contributor

@MarcelBochtler MarcelBochtler commented Jul 15, 2025

This was incorrectly removed in #225

This avoids overriding the `INDEX_URL` tuple in `Settings` with the
default value from `click` and enables the use of environment variables
for `PYINSP_INDEX_URL`.

Signed-off-by: Marcel Bochtler <[email protected]>
Signed-off-by: Marcel Bochtler <[email protected]>
@MarcelBochtler
Copy link
Contributor Author

MarcelBochtler commented Jul 18, 2025

@pombredanne Can you please take a look?

@MarcelBochtler MarcelBochtler changed the title Enable envvar usage for click options Use default INDEX_URL from Settings Jul 21, 2025
@MarcelBochtler MarcelBochtler changed the title Use default INDEX_URL from Settings Use default INDEX_URL from Settings to use environment variables Jul 21, 2025
@sschuberth
Copy link
Contributor

@pombredanne / @tsteenbe can we please merge this trivial PR ASAP for OCCTET use?

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @MarcelBochtler, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 3ad3925 into aboutcode-org:main Jul 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants