Skip to content

AML- 8 DATA API support for automatically zipping/unzipping nested directories #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 5, 2021

Conversation

zeryx
Copy link
Contributor

@zeryx zeryx commented Oct 1, 2021

This PR adds the following two methods getAsZip() and putAsZip(path) to the DataFile class.

putAsZip() - accepts both a single file, or a directory containing other files and directories; will zip everything into a zipfile and upload that to the data API location defined by the DataFile object.

getAsZip() - expects the DataFile object to point to a zip compatible data API location, downloads and decompresses file / directories, and either returns the directory or a path to the file; depending on if a directory or file was zipped.

This is useful for existing customer engagements, but also directory structures are required for transformers and tensorflow workflows.

@zeryx zeryx requested review from kennydaniel and lemonez October 1, 2021 17:28
@zeryx zeryx self-assigned this Oct 1, 2021
@zeryx zeryx changed the title AML- 8 DATA APIsupport for automatically zipping/unzipping nested directories AML- 8 DATA API support for automatically zipping/unzipping nested directories Oct 1, 2021
lemonez
lemonez previously approved these changes Oct 1, 2021
Copy link
Contributor

@lemonez lemonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added a few docstrings from the PR content

zeryx and others added 2 commits October 2, 2021 04:54
Co-authored-by: lemonez <[email protected]>
Co-authored-by: lemonez <[email protected]>
@zeryx zeryx requested a review from lemonez October 4, 2021 17:21
Copy link
Contributor

@lemonez lemonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this docstring update, looks good.

@zeryx zeryx requested a review from lemonez October 5, 2021 14:55
@zeryx zeryx merged commit dda808e into develop Oct 5, 2021
@zeryx zeryx deleted the AML-8-directory-zipping branch October 5, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants