Skip to content

removal of api-client utilization for algo.publish #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions Algorithmia/algorithm.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,19 @@ def update(self, details={}, settings={}, version_info={}):

# Publish an algorithm
def publish(self, details={}, settings={}, version_info={}):
detailsObj = Details(**details)
settingsObj = SettingsPublish(**settings)
versionRequestObj = VersionInfoPublish(**version_info)
publish_parameters = {"details": detailsObj, "settings": settingsObj, "version_info": versionRequestObj}
version_request = VersionRequest(**publish_parameters) # VersionRequest | Publish Version Request
try:
# Publish Algorithm
api_response = self.client.manageApi.publish_algorithm(self.username, self.algoname, version_request)
return api_response
except ApiException as e:
error_message = json.loads(e.body)
raise raiseAlgoApiError(error_message)
# detailsObj = Details(**details)
# settingsObj = SettingsPublish(**settings)
# versionRequestObj = VersionInfoPublish(**version_info)
# publish_parameters = {"details": detailsObj, "settings": settingsObj, "version_info": versionRequestObj}
# version_request = VersionRequest(**publish_parameters) # VersionRequest | Publish Version Request
publish_parameters = {"details": details, "settings": settings, "version_info": version_info}
url = "/v1/algorithms/"+self.username+"/"+self.algoname + "/versions"
print(publish_parameters)
api_response = self.client.postJsonHelper(url, publish_parameters, parse_response_as_json=True, **self.query_parameters)
return api_response
# except ApiException as e:
# error_message = json.loads(e.body)
# raise raiseAlgoApiError(error_message)

def builds(self, limit=56, marker=None):
try:
Expand Down
2 changes: 1 addition & 1 deletion Test/client_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def test_algorithm_programmatic_create_process(self):
settings=pub_settings,
version_info=pub_version_info
)
self.assertEqual(response.version_info.semantic_version, "0.1.0", "Publishing failed, semantic version is not correct.")
self.assertEqual(response["version_info"]["semantic_version"], "0.1.0", "Publishing failed, semantic version is not correct.")

# --- publishing complete, getting additional information

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ enum-compat
toml
argparse
algorithmia-api-client==1.5.1
algorithmia-adk>=1.0.4,<1.1
algorithmia-adk>=1.1,<1.2
numpy<2
uvicorn==0.14.0
fastapi==0.65.2
2 changes: 1 addition & 1 deletion requirements27.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ enum-compat
toml
argparse
algorithmia-api-client==1.5.1
algorithmia-adk>=1.0.4,<1.1
algorithmia-adk>=1.1,<1.2
numpy<2
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'toml',
'argparse',
'algorithmia-api-client==1.5.1',
'algorithmia-adk>=1.0.2,<1.1'
'algorithmia-adk>=1.1,<1.2'
],
include_package_data=True,
classifiers=[
Expand Down