Skip to content

Async Support #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2021
Merged

Async Support #117

merged 4 commits into from
Nov 9, 2021

Conversation

zeryx
Copy link
Contributor

@zeryx zeryx commented Nov 9, 2021

This PR adds two tests for Async Response processing, and ensures that AsyncResponse objects are not detected as errors

@zeryx zeryx self-assigned this Nov 9, 2021
aslisabanci
aslisabanci approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@aslisabanci aslisabanci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't notice anything weird by reading the code, so 👍

@zeryx zeryx merged commit 1d26de1 into develop Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslisabanci aslisabanci aslisabanci approved these changes

@kennydaniel kennydaniel Awaiting requested review from kennydaniel

Assignees

@zeryx zeryx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeryx @aslisabanci