Customize GC behavior #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite my best efforts at .dockerignore'ing things, adding all of . would always blow the layer cache. This change ensures that only changes to the source files themselves will trigger compilation.
By default, the JVM does not free allocated heap back to the OS. This configures away from that behavior, hopefully to prevent OOM engine errors. See http://www.stefankrause.net/wp/?p=14 for details on the specific options chosen. Of all the examples in that post, this one performed the best and brought my test repository's memory usage down from ~700MB to ~150MB. Its graph also shows most closely the pattern we'd prefer: the slope of allocated heap closely matching used.
|
Thanks @pbrisbin, very nice tunning! |
|
Just a heads up: I noticed a deprecation warning for this configuration after the fact. I'm inclined to keep using it anyway because it did give the best performance. If/when they fully remove the support for it, we'll likely have to use |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @andrewhr, I'm an engineer at Code Climate and was looking into some
out-of-memory errors we see on this engine. I think I've got a fix here by way
of tuning the GC -- let me know what you think.
By default, the JVM does not free allocated heap back to the OS. This
configures away from that behavior, hopefully to prevent OOM engine
errors.
See http://www.stefankrause.net/wp/?p=14 for details on the specific
options chosen. Of all the examples in that post, this one performed the
best and brought my test repository's memory usage down from ~700MB to
~150MB. Its graph also shows most closely the pattern we'd prefer: the
slope of allocated heap closely matching used.