Skip to content

Add in authentication #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jcreamer898
Copy link

Hey Andrew!
I went ahead and added some auth features.

The basic idea is that you can now do...

nserver --auth p@ssw0rd

Then when the user hits localhost:8000, they'll be directed to a login screen.

The login screen will prompt for a password.

Once the correct password has been entered, the duration of the session will not require any further authentication and will work as normal.

Let me know if you love or hate this, or have any additional questions.

Thanks!

@andrewpthorp
Copy link
Owner

Hey, sorry to take so long to respond to this! Have you considered using HTTP Basic Auth instead of building your own logic here?

@emlama
Copy link

emlama commented Nov 25, 2013

I agree, HTTP Basic Auth seems to keep with the 'simple' theme of this server.

@andrewpthorp
Copy link
Owner

I would love someone to go with an HTTP Basic Auth solution! I don't have the time right now, unfortunately :\

@jcreamer898
Copy link
Author

I'll see if I can look into it.

On Sunday, November 24, 2013, Andrew Thorp wrote:

I would love someone to go with an HTTP Basic Auth solution! I don't have
the time right now, unfortunately :\


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-29176100
.


Jonathan Creamer http://jcreamerlive.com
615-392-0809

@emlama
Copy link

emlama commented Nov 25, 2013

That would be great, let me know if you want some help on this. I should have time over the holiday weekend :)

@jcreamer898
Copy link
Author

Oh, I'd love some help. If you already have some ideas than have at it!


Jonathan Creamer http://jcreamerlive.com
615-392-0809

On Mon, Nov 25, 2013 at 9:24 AM, Matthew Forr [email protected]:

That would be great, let me know if you want some help on this. I should
have time over the holiday weekend :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-29209969
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants