Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Bootstrap3 bis2 Accordion & Collapse #1208

Closed
wants to merge 22 commits into from
Closed

Bootstrap3 bis2 Accordion & Collapse #1208

wants to merge 22 commits into from

Conversation

f2net
Copy link

@f2net f2net commented Oct 25, 2013

I've build the Bootstrap3_bis2 solution, but I see that in the Demo Accordion and Collapse don't work properly, as they remain always collapsed.
I've seen that the problem is in the Collapse module, because the expand method never switches the class ".collapse" (which has display:none) with the class ".in".

.collapse {
display: none;
}

.collapse.in {
display: block;
}

I see that Bootstrap 3 Js also sets a "collapsing" class during collapse/expand (maybe useless with angular-ui javascript):

.collapsing {
position: relative;
height: 0;
overflow: hidden;
-webkit-transition: height 0.35s ease;
transition: height 0.35s ease;
}

Thank you,
Matteo

@pkozlowski-opensource
Copy link
Member

@f2net I don't think you wanted to open this pull request...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants