This repository was archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds functionality for justifed tabs http://getbootstrap.com/components/#nav-justified
@f2net I don't think you wanted to open this pull request... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've build the Bootstrap3_bis2 solution, but I see that in the Demo Accordion and Collapse don't work properly, as they remain always collapsed.
I've seen that the problem is in the Collapse module, because the expand method never switches the class ".collapse" (which has display:none) with the class ".in".
.collapse {
display: none;
}
.collapse.in {
display: block;
}
I see that Bootstrap 3 Js also sets a "collapsing" class during collapse/expand (maybe useless with angular-ui javascript):
.collapsing {
position: relative;
height: 0;
overflow: hidden;
-webkit-transition: height 0.35s ease;
transition: height 0.35s ease;
}
Thank you,
Matteo