Require angular-mocks

[aciccarello]

I recognize that this change is in the bower repo, but there is a pull request sitting out that that isn't getting much love. Just thought I'd bring it to the maintainer's attention.

This makes angular-mocks require-able like the other angular repos.
angular/bower-angular-mocks#17

[Narretz]

The bower repos are generated, so I think the change must be made in this repo somewhere. Also, the other bower repos have an "index.js" not an .js.

[aciccarello]

Right, I think the package.json is generated. The other PRs in that repo are on non-generated files though.

I think the file is not named index.js because there are actually 3 separate modules listed (ngAnimateMock, ngMock, and ngMockE2E).

[aciccarello]

Upon further investigation, it seems the package.json needs to be updated in the bower repo. My understanding of publish.js is that the file's version property is updated, leaving everything else.

[gkalpak]

I too think that these files are not generated. But the problem remains, that angular-mocks exposes 3 modules, not just ngMock.

[gkalpak]

BTW, this was decided extensively in #10732.

[aciccarello]

Thanks @gkalpak. @petebacondarwin's comment goes over how the package.json file is managed in the bower repo.

The remaining question is what should be the default commonJS export. As I think about it, it may not make sense to go with angular/bower-angular-mocks#17 because of the multiple modules. The only alternative would be an index.js file with properties of the module names similar to how @bclinkinbeard mentioned in that same thread. I like that style more but it would probably be a breaking change for people using a CommonJS build.

Even if that isn't changed. Someone should look at the other PRs in the bower repo.

[aciccarello]

I'm closing this as I think the existing entry file setup is fine because there are multiple files.

The PRs on the repo should still be looked at 😉