Weird interaction between nested forms and directives

[nilpath]

Hi

I've just updated my code to use angular 1.2-rc2 and found that when using a custom directive with replace: true and that includes an ng-form, the form elements are attached to the parent form rather than the nested form.

changing the templateUrl to an inline template or setting replace: false solves this but doesn't seem right that it's not working with this particular setup as well..

heres a plunkr with 1.2-rc2
http://plnkr.co/edit/zcvaSl13HgkSiuCOiMut?p=preview

[nilpath]

might have something in common with #3923

[nilpath]

might also be fixed in RC3 with this PR (#3927)

[petebacondarwin]

@nilpath - Can you check against master since there has been some work on this area of the code?

[nilpath]

@petebacondarwin tested with master (v1.2.0-e4415d2) (plunker: http://plnkr.co/edit/uY6W1n6NMBROUG66V7Fh?p=preview) and it seem to still have the same problem

[jankuca]

The problem is in timing. The inner form controller is created (and the directive is linked) after the ngModel directive of the inner form element. That leads to the element being registered (via $addControl) on the outer form as the inner form controller is not associated with the div[ng-form="inner"] element at the time of running getControllers() inside of the compiler.

[jankuca]

The PR #3927 should fix this I think.

[btford]

Here's the plunkr with the patch from PR #3927: http://plnkr.co/edit/Hr0th7kr3eVGves5GFd4?p=preview

Seems like Vojta's PR fixes it, if I understand the test correctly.

[nilpath]

nicley done! 👍