Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(migration): add end to end upgrade info to migration doc #10377

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions docs/content/guide/migration.ngdoc
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,45 @@ After:
Please view the documentation for ngAnimate for more info.


## Testing

- due to [85880a64](https://github.com/angular/angular.js/commit/85880a64900fa22a61feb926bf52de0965332ca5), some deprecated features of
Protractor tests no longer work.

`by.binding(descriptor)` no longer allows using the surrounding interpolation
markers in the descriptor (the default interpolation markers are `{{}}`).
Previously, these were optional.

Before:

var el = element(by.binding('{{foo}}'));

After:

var el = element(by.binding('foo'));

Prefixes `ng_` and `x-ng-` are no longer allowed for models. Use `ng-model`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about data-ng- and ng: ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are still fine!


`by.repeater` cannot find elements by row and column which are not children of
the row. For example, if your template is

<div ng-repeat="foo in foos">{{foo.name}}</div>

Before:

var el = element(by.repeater('foo in foos').row(2).column('foo.name'))

After:

You may either enclose `{{foo.name}}` in a child element

<div ng-repeat="foo in foos"><span>{{foo.name}}</span></div>

or simply use:

var el = element(by.repeater('foo in foos').row(2))


## Internet Explorer 8

- due to [eaa1d00b](https://github.com/angular/angular.js/commit/eaa1d00b24008f590b95ad099241b4003688cdda),
Expand Down