Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($injector): Reword fn param docs and link to DI information #4202

Closed
wants to merge 1 commit into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Sep 30, 2013

The documentation for $injector.invoke is currently very unclear, and contains a typographic error.

I'd like to link to the more detailed DI docs instead of simply stating "function annotation" as though that means something out of context.


note: I'm not sure if I need to specify this link as an external link or not. If it's possible, please let me know so I can correct this.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@caitp
Copy link
Contributor Author

caitp commented Sep 30, 2013

I've signed the CLA previously for #4078

Build failure appears to be unrelated to these changes -- Also FF saucelabs build didn't start.

@btford
Copy link
Contributor

btford commented Oct 1, 2013

Yep, ignore the travis failure.

@ghost ghost assigned btford Oct 1, 2013
@btford
Copy link
Contributor

btford commented Oct 1, 2013

You don't have to specify the full path in your link. I took care of making that little change.

Landed as ba38de2. Thanks!

@btford btford closed this Oct 1, 2013
@caitp caitp deleted the docs-injector.invoke branch October 1, 2013 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants