-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Some grammar corrections "it's" vs "its" #7580
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
@@ -222,7 +222,7 @@ var $AnimateProvider = ['$provide', function($provide) { | |||
* @function | |||
* @description Adds and/or removes the given CSS classes to and from the element. | |||
* Once complete, the done() callback will be fired (if provided). | |||
* @param {DOMElement} element the element which will it's CSS classes changed | |||
* @param {DOMElement} element the element which will its CSS classes changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're editing this: maybe it should say 'the element which will HAVE its CSS classes changed'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you that since I'm in here I might as well correct an obvious oversight. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. CLA just scanned and emailed to [email protected]
Phil
On 28 May 2014, at 17:46, pomerantsev [email protected] wrote:
In src/ng/animate.js:
@@ -222,7 +222,7 @@ var $AnimateProvider = ['$provide', function($provide) {
* @function
* @description Adds and/or removes the given CSS classes to and from the element.
* Once complete, the done() callback will be fired (if provided).
\* @param {DOMElement} element the element which will it's CSS classes changed
Since you're editing this: maybe it should say 'the element which will HAVE its CSS classes changed'?\* @param {DOMElement} element the element which will its CSS classes changed
—
Reply to this email directly or view it on GitHub.
LGTM |
Request Type: docs
How to reproduce:
Component(s):
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Fixes to grammar in text. No other impact. Two of changes affect the titles of tests so had to be escaped.
Other Comments:
Minor fix. This should account for all such errors.