Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add karma config update reference to step 11 of the tutorial #7651

Closed
wants to merge 1 commit into from

Conversation

aschokking
Copy link
Contributor

Request Type: docs

How to reproduce: On step 11 of the tutorial if you just follow the instructions on the main page the unit tests will fail.

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

When including the ng-resource module you appear to need to add a reference to the karma config file as well or the unit tests will fail. This burned me for a while when going through the tutorial.

Other Comments:

When including the ng-resource module you appear to need to add a reference to the karma config file as well or the unit tests will fail. This burned me for a while when going through the tutorial.
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7651)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@aschokking aschokking changed the title Add karma config update reference Add karma config update reference to step 11 of the tutorial May 31, 2014
@caitp
Copy link
Contributor

caitp commented May 31, 2014

LGTM

@caitp caitp added this to the 1.3.0-beta.11 milestone May 31, 2014
@caitp caitp closed this in 42a367d May 31, 2014
@caitp
Copy link
Contributor

caitp commented May 31, 2014

I've changed the text very slightly, and moved it to before the tests are written, so that people following the tutorial can get working tests faster. If you think it's bad, PRs to fix it are welcome, I'm tired and my documentation poetry is not at 100% right now =)

@aschokking
Copy link
Contributor Author

Sounds reasonable, thanks!

@jmpalacios
Copy link
Contributor

Hey @caitp!

I also reported the same problem in #7575, also clarifying that the Karma test run needs to be restarted after its conf file is modified to include the ngResource module, because new modules are not autoloaded and therefore tests will just keep on failing due to the lack of ngResource.

You might want to also address that in the docs and close my issue. Regards!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants