Skip to content

docs(overlay): Minor comment fix in overlay.ts #17329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

NothingEverHappens
Copy link
Contributor

cc @thekiba who helped me understand it

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the message should be docs instead of fix.

@crisbeto crisbeto added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 8, 2019
@NothingEverHappens NothingEverHappens changed the title fix(overlay): Minor comment fix in overlay.ts docs(overlay): Minor comment fix in overlay.ts Oct 8, 2019
@NothingEverHappens
Copy link
Contributor Author

Thanks, updated

@mmalerba mmalerba merged commit 1a589ce into angular:master Oct 8, 2019
@zolee
Copy link

zolee commented Oct 9, 2019

As I see line 32 looks like this after merge:
Note that Overlay is not scoped to the app root because the of the ComponentFactoryResolver

Please observ the bold part, it still incorrect I think, It simply should be of the.

@NothingEverHappens
Copy link
Contributor Author

Ah, good catch, let me re-fix this

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants