-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/autocomplete/testing): polish harness API #17350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/autocomplete/testing): polish harness API #17350
Conversation
d1a73e4
to
38ea57a
Compare
38ea57a
to
473e75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from small nits, add merge-ready when ready
809a0ca
to
0e50b9c
Compare
0e50b9c
to
c2b13de
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds:
MatAutocompleteHarness
based onvalue
getOptions
withOptionHarnessFilters
getOptionGroups
withOptionGroupHarnessFilters
Removes:
MatAutocompleteHarness#getAttribute
(prefer more focused APIs)MatAutocompleteHarness#getPanel
(want to avoid returningTestElement
, prefer more focused APIs)MatAutocompleteHarness#isPanelVisible
(combined intoisOpen
)Renames:
MatAutocompleteHarness#getText
-->MatAutocompleteHarness#getValue
MatOptionGroupHarness#getLabelText
-->MatOptionGroupHarness#getText