Skip to content

build: re-enable release output validation for source maps #17462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2019
Merged

build: re-enable release output validation for source maps #17462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tools/release/release-output/output-validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ export function checkReleaseBundle(bundlePath: string): string[] {
const failures: string[] = [];

if (inlineStylesSourcemapRegex.exec(bundleContent) !== null) {
// TODO(devversion): check if we can omit the invalid source-map references
// for built components. For now this check is temporarily disabled.
// failures.push('Found sourcemap references in component styles.');
failures.push('Found sourcemap references in component styles.');
}

if (externalReferencesRegex.exec(bundleContent) !== null) {
Expand Down