Skip to content

refactor(cdk/drag-drop): convert all directives to standalone #26135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2022
Merged

refactor(cdk/drag-drop): convert all directives to standalone #26135

merged 4 commits into from
Dec 5, 2022

Conversation

ShauniArima
Copy link
Contributor

@ShauniArima ShauniArima commented Nov 30, 2022

This work converts all of the @angular/cdk/drag-drop directives to standalone. With these changes, drag-drop directives can be used as host directives.

@google-cla
Copy link

google-cla bot commented Nov 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ShauniArima
Copy link
Contributor Author

Hello 👋
I do not know which label I can put on that PR. Would you help me with it?

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 5, 2022
@crisbeto crisbeto self-assigned this Dec 5, 2022
@crisbeto crisbeto merged commit 30c6c8f into angular:main Dec 5, 2022
crisbeto pushed a commit that referenced this pull request Dec 5, 2022
* refactor(cdk/drag-drop): convert all directives to standalone

* refactor(cdk/drag-drop): import directives in the module

* fix(cdk/drag-drop): remove declarations from DragDropModule

* refactor(cdk/drag-drop): update public api guard

(cherry picked from commit 30c6c8f)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Dec 9, 2022
…r#26135)

* refactor(cdk/drag-drop): convert all directives to standalone

* refactor(cdk/drag-drop): import directives in the module

* fix(cdk/drag-drop): remove declarations from DragDropModule

* refactor(cdk/drag-drop): update public api guard
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants