fix(material/dialog): use custom token to disable animations #31156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the `MatDialogOpener` was using the `NoopAnimationsModule` to disable animations which requires user to have `@angular/animations` installed. These changes switch to using `MATERIAL_ANIMATIONS` in the `MatTestDialogOpenerModule` and setting the animation durations to zero in case the module isn't used. Fixes angular#31145.
crisbeto
requested review from
adolgachev and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
May 20, 2025
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
May 20, 2025
Fixes that the `MatDialogOpener` was using the `NoopAnimationsModule` to disable animations which requires user to have `@angular/animations` installed. These changes switch to using `MATERIAL_ANIMATIONS` in the `MatTestDialogOpenerModule` and setting the animation durations to zero in case the module isn't used. Fixes #31145. (cherry picked from commit 2971f13)
crisbeto
added a commit
that referenced
this pull request
May 20, 2025
Fixes that the `MatDialogOpener` was using the `NoopAnimationsModule` to disable animations which requires user to have `@angular/animations` installed. These changes switch to using `MATERIAL_ANIMATIONS` in the `MatTestDialogOpenerModule` and setting the animation durations to zero in case the module isn't used. Fixes #31145. (cherry picked from commit 2971f13)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 21, 2025
…ngular#31156)" This reverts commit af04c77.
crisbeto
added a commit
that referenced
this pull request
May 21, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
MatDialogOpenerwas using theNoopAnimationsModuleto disable animations which requires user to have@angular/animationsinstalled.These changes switch to using
MATERIAL_ANIMATIONSin theMatTestDialogOpenerModuleand setting the animation durations to zero in case the module isn't used.Fixes #31145.