fix(material/radio): assistive technology announcing button as invalid #31160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
May 20, 2025
mmalerba
approved these changes
May 21, 2025
Fixes that some screen readers were reading out "required, invalid data" for radio buttons that were marked as required. The problem was triggered by us using the `required` attribute and the fix is to add `aria-invalid="false"` to it. Note that an alternate approach is to use `aria-required` instead, but there are some internal checks that require both `aria-required` and `required` to be set which re-introduces the issue. Fixes angular#30761.
crisbeto
force-pushed
the
30761/button-aria-required
branch
from
c570057 to
3e650d5
Compare
|
I changed the approach here a bit, because there was an internal check requiring that |
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
May 21, 2025
#31160) Fixes that some screen readers were reading out "required, invalid data" for radio buttons that were marked as required. The problem was triggered by us using the `required` attribute and the fix is to add `aria-invalid="false"` to it. Note that an alternate approach is to use `aria-required` instead, but there are some internal checks that require both `aria-required` and `required` to be set which re-introduces the issue. Fixes #30761. (cherry picked from commit cf83272)
crisbeto
added a commit
that referenced
this pull request
May 21, 2025
#31160) Fixes that some screen readers were reading out "required, invalid data" for radio buttons that were marked as required. The problem was triggered by us using the `required` attribute and the fix is to add `aria-invalid="false"` to it. Note that an alternate approach is to use `aria-required` instead, but there are some internal checks that require both `aria-required` and `required` to be set which re-introduces the issue. Fixes #30761. (cherry picked from commit cf83272)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that some screen readers were reading out "required, invalid data" for radio buttons that were marked as required. The problem was triggered by us using the
requiredattribute and the fix is to addaria-invalid="false"to it.Note that an alternate approach is to use
aria-requiredinstead, but there are some internal checks that require botharia-requiredandrequiredto be set which re-introduces the issue.Fixes #30761.