Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(element): removed WebElement getSize and getLocation for getRect #5227

Merged
merged 2 commits into from
Jun 6, 2019
+2 −3
Merged

fix(element): removed WebElement getSize and getLocation for getRect #5227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b517d6
fix(element): removed WebElement getSize and getLocation for getRect
kolodiy Apr 30, 2019
ea2ef05
fix(element): removed WebElement getSize and getLocation for getRect
kolodiy Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ export class WebdriverWebElement {}
export interface WebdriverWebElement extends WebElement { [key: string]: any; }

let WEB_ELEMENT_FUNCTIONS = [
'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getSize',
'getLocation', 'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId',
'takeScreenshot'
'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getRect',
'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId', 'takeScreenshot'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDisplayed also removed. Or here we use own script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CrispusDH , I still see isDisplayed in https://github.com/SeleniumHQ/selenium/blob/selenium-4.0.0-alpha-1/javascript/node/selenium-webdriver/lib/webdriver.js. Also it is listed in the dependency spec, please see: spec/dependencyTest/seleniumWebdriver_spec.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is right. I did not clean up this list.

];

/**
Expand Down