Skip to content

[DataFrame] - Add DataFrame::distinct binding #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

francis-du
Copy link
Contributor

Close #29

@andygrove
Copy link
Member

Thanks @francis-du! It looks like there is a Clippy issue on all of these PRs.

@andygrove
Copy link
Member

There are clippy failures like this - not related to your changes:

4 |         default_catalog: &str,
   |                          ^ help: if you would like to reborrow, try removing `&*`: `&`

I saw these recently on another project. We probably need to switch to using String instead of &str in pyo3 methods. Not sure why we are suddenly seeing this now though.

@francis-du
Copy link
Contributor Author

francis-du commented Aug 19, 2022

This is a new lint in release 1.63.0
https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

I will reopen a new PR to fix this issue

@andygrove
Copy link
Member

@francis-du could you merge latest from master on these PRs? I fixed the clippy issue

@francis-du
Copy link
Contributor Author

@francis-du could you merge latest from master on these PRs? I fixed the clippy issue

OK 👌

@andygrove
Copy link
Member

Looks like a linting issue

@francis-du
Copy link
Contributor Author

Looks like a linting issue

It has been fixed, please review

@andygrove
Copy link
Member

Thanks @francis-du!

@andygrove andygrove merged commit d083d97 into apache:master Sep 8, 2022
@francis-du francis-du deleted the df_distinct_fun branch November 11, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python binding for DataFrame::distinct
2 participants