Skip to content

fix: allow snowflake to accept values without parens #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024

Conversation

HiranmayaGundu
Copy link
Contributor

Snowflake and Databricks both allow:

"SELECT * FROM VALUES (1, 2), (2,3) AS tbl (id, val)";

this adds support for that

@HiranmayaGundu HiranmayaGundu force-pushed the hiran/fix-values-parens-2 branch from 39ed016 to a117aab Compare May 3, 2024 19:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8943938289

Details

  • 44 of 48 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 16 17 94.12%
tests/sqlparser_common.rs 28 31 90.32%
Totals Coverage Status
Change from base Build 8943500950: 0.02%
Covered Lines: 24225
Relevant Lines: 27162

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @HiranmayaGundu

@alamb alamb merged commit 2555f71 into apache:main May 3, 2024
@HiranmayaGundu HiranmayaGundu deleted the hiran/fix-values-parens-2 branch May 3, 2024 20:21
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants