alter interval to support postgres syntax #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolay
approved these changes
Jun 7, 2020
This patch updates our INTERVAL implementation such that the Postgres and Redshfit variation of the syntax is supported: namely that leading field is optional. Fixes apache#177.
maxcountryman
force-pushed
the
feature/postgres-interval
branch
from
43ee97e to
d093f7f
Compare
Pull Request Test Coverage Report for Build 128650182
💛 - Coveralls |
maxcountryman
commented
Jun 8, 2020
Comment on lines
+530
to
+532
| if ["YEAR", "MONTH", "DAY", "HOUR", "MINUTE", "SECOND"] | ||
| .iter() | ||
| .any(|d| kw.keyword == *d) => |
There was a problem hiding this comment.
I'm not entirely sure about this approach, but it does seem to work. I certainly would appreciate your thoughts. 🙂
There was a problem hiding this comment.
I guess this will do for now, seems like a good place to use the maybe_parse helper from a sibling PR, as well as parse_set https://github.com/andygrove/sqlparser-rs/blob/d842f495db6936f64b2738178a431f0ebd6c4e07/src/parser.rs#L1769-L1770
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates our INTERVAL implementation such that the Postgres
and Redshfit variation of the syntax is supported: namely that leading
field is optional.
Fixes #177.