Skip to content

fix: parse snowflake fetch clause #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 24, 2025
Merged

fix: parse snowflake fetch clause #1894

merged 4 commits into from
Jun 24, 2025

Conversation

Vedin
Copy link
Contributor

@Vedin Vedin commented Jun 19, 2025

Snowflake treat FETCH in a different way. https://docs.snowflake.com/en/sql-reference/constructs/limit
Most keywords like FIRST/NEXT, ROW/ROWS and ONLY can be skipped.
PERSENT and WITH TIES should cause an error.

iffyio
iffyio reviewed Jun 21, 2025
View reviewed changes
@Vedin Vedin force-pushed the fix-snowflake-fetch-clause branch from c5c9f1e to 68d8d87 Compare June 23, 2025 13:14
@Vedin
Revert "Fix tests"
6062c06 
This reverts commit 50ee50a.
@Vedin Vedin requested a review from iffyio June 23, 2025 13:20
iffyio
iffyio approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Vedin!
cc @alamb

@iffyio iffyio merged commit 44f3be3 into apache:main Jun 24, 2025
10 checks passed
Vedin added a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Jun 24, 2025
@Vedin
fix: parse snowflake fetch clause (apache#1894)
97c03c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vedin @iffyio