Skip to content

support MySQL quote style like BEGIN #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

miuy56dc
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jul 29, 2020

Pull Request Test Coverage Report for Build 187886211

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.79%

Totals Coverage Status
Change from base Build 186377189: 0.05%
Covered Lines: 4405
Relevant Lines: 4799

💛 - Coveralls

Copy link
Contributor

@nickolay nickolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'd prefer the test for back-ticked identifiers to be in parse_identifiers or in a separate test, instead of being combined with the test for AUTO_INCREMENT.

@nickolay nickolay merged commit 9e7e302 into apache:main Jul 30, 2020
@nickolay
Copy link
Contributor

nickolay commented Jul 30, 2020

Excellent, thanks! I noticed (after merging) that https://dev.mysql.com/doc/refman/8.0/en/identifiers.html says MySQL also supports normal "double quotes" in ANSI_QUOTES mode, while with this patch the MySQL dialect doesn't seem parse those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants