Support table function derived table #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalleshem
force-pushed
the
table_function_2
branch
from
49a7a21 to
c769102
Compare
Pull Request Test Coverage Report for Build 194907691
💛 - Coveralls |
nickolay
suggested changes
Aug 2, 2020
eyalleshem
force-pushed
the
table_function_2
branch
2 times, most recently
from
06ee16b to
d9a78aa
Compare
Dandandan
reviewed
Aug 2, 2020
eyalleshem
force-pushed
the
table_function_2
branch
from
d9a78aa to
43f3be6
Compare
nickolay
approved these changes
Aug 2, 2020
There was a problem hiding this comment.
LGTM, thanks! Waiting for @Dandandan to comment what the TABLE(...) formatting should be.
eyalleshem
force-pushed
the
table_function_2
branch
4 times, most recently
from
ff197b6 to
7297eb8
Compare
for example: "select * from TABLE(SOME_FUNCTION(some_arg))" see : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#table-function-derived-table
eyalleshem
force-pushed
the
table_function_2
branch
from
7297eb8 to
85e8055
Compare
|
sorry for all the commit's - i got into some mess between my branch's , |
Dandandan
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
TABLE(...)syntax inFROM, for example:The ANSI spec allows routine invocations (and some other kinds of expressions we don't currently support) inside TABLE:
https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#PTF-derived-table
https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#table-function-derived-table