feat(spark): Implement Spark string function luhn_check
#16848
+400
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
changed the title
string function luhn_check
Standing-Man
commented
Jul 22, 2025
Comment on lines
+117
to
+126
| query error | ||
| select luhn_check(6011111111111117::BIGINT) | ||
|
|
||
|
|
||
| query error | ||
| select luhn_check(6011111111111118::BIGINT) | ||
|
|
||
|
|
||
| query error | ||
| select luhn_check(123.456::decimal(6,3)) |
There was a problem hiding this comment.
Hi @comphead, For inputs like fractional, exponential, or negative numbers, the current implementation just reports that luhn_check doesn't support them. I'm not sure if that's the right approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914.stringfunctionluhn_check#16612 and the draft [datafusion-spark] Implement Sparkluhn_checkfunction #16580.Rationale for this change
WIP: adding the suggestion.
What changes are included in this PR?
Implement Spark
luhn_checkfunctionAre these changes tested?
Yes
Are there any user-facing changes?
Yes