KAFKA-18845: Fix flaky QuorumControllerTest#testUncleanShutdownBrokerElrEnabled #19240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ElrEnabled Signed-off-by: PoAn Yang <[email protected]>
github-actions
bot
added
tests
mumrah
requested changes
Mar 19, 2025
| @@ -376,10 +375,12 @@ public void testElrEnabledByDefault() throws Throwable { | |||
| } | |||
| } | |||
|
|
|||
| @Flaky("KAFKA-18845") | |||
There was a problem hiding this comment.
@FrankYang0529 we need to keep the annotation here until the test proves itself to no longer be flaky. I have updated the wiki https://cwiki.apache.org/confluence/display/KAFKA/Flaky+Test+Management to reflect this
There was a problem hiding this comment.
Thanks for the reminder. I added Flaky back and will remove it after we have sufficient data.
mumrah
reviewed
Mar 19, 2025
| setListeners(listeners)); | ||
| brokerEpochs.put(brokerToBeTheLeader, replyLeader.get().epoch()); | ||
| partition = active.replicationControl().getPartition(topicIdFoo, 0); | ||
| assertArrayEquals(new int[]{brokerToBeTheLeader}, partition.elr, partition.toString()); |
There was a problem hiding this comment.
How about a real message instead of just the partition if the assertion fails?
There was a problem hiding this comment.
Add more content for it. Thanks.
Signed-off-by: PoAn Yang <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Apr 15, 2025
…ownBrokerElrEnabled (#19403) It has been around two weeks since fixing QuorumControllerTest#testUncleanShutdownBrokerElrEnabled PR #19240 was merged. There is no flaky result after 2025/03/21, so it has enough evidence to prove the flaky is fixed. It's good to remove flaky tag. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're two root causes:
brokerToBeTheLeader, we didn't wait for the result. That means when we send heartbeat to unfence broker, it has chance to use stale broker epoch to send the request. [0]brokerToBeTheLeadercannot be elected as a new leader. [1][0]
kafka/metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
Lines 484 to 497 in a5325e0
[1]
kafka/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
Lines 2470 to 2477 in a5325e0
Reviewers: David Arthur [email protected]