KAFKA-14690; Add TopicId to OffsetCommit API #19461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 12 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (11)
- clients/src/main/resources/common/message/OffsetCommitRequest.json: Language not supported
- clients/src/main/resources/common/message/OffsetCommitResponse.json: Language not supported
- core/src/main/scala/kafka/server/KafkaApis.scala: Language not supported
- core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/DeleteGroupsRequestTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/OffsetDeleteRequestTest.scala: Language not supported
- core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: Language not supported
Comments suppressed due to low confidence (2)
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java:425
- [nitpick] Consider using a fixed Uuid value in tests for version >= 10 instead of Uuid.randomUuid() to ensure determinism and avoid flaky test behavior.
.setTopicId(version >= 10 ? Uuid.randomUuid() : Uuid.ZERO_UUID)
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:244
- Add tests to verify that the builder correctly throws an exception when a null TopicId is provided, ensuring that the new validation logic is covered.
if (topicId == null) { throw new IllegalArgumentException("TopicId cannot be null."); }
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java
Show resolved
Hide resolved
lianetm
reviewed
Apr 16, 2025
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java
Outdated
Show resolved
Hide resolved
clients/src/main/resources/common/message/OffsetCommitRequest.json
Outdated
Show resolved
Hide resolved
clients/src/main/resources/common/message/OffsetCommitResponse.json
Outdated
Show resolved
Hide resolved
...-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java
Show resolved
Hide resolved
lianetm
approved these changes
Apr 22, 2025
| "flexibleVersions": "8+", | ||
| "latestVersionUnstable": true, |
There was a problem hiding this comment.
do we need a Jira to mark this as stable later on? (I guess we'll wait to complete the broker side, and the client side, just in case we decide to adjust something along the way?)
There was a problem hiding this comment.
Yes. We can mark is as stable once we are confident on the client side. Opened https://issues.apache.org/jira/browse/KAFKA-19186.
| @@ -727,7 +727,7 @@ public NetworkClientDelegate.UnsentRequest toUnsentRequest() { | |||
| lastEpochSentOnCommit = Optional.empty(); | |||
| } | |||
|
|
|||
| OffsetCommitRequest.Builder builder = new OffsetCommitRequest.Builder(data); | |||
| OffsetCommitRequest.Builder builder = OffsetCommitRequest.Builder.forTopicNames(data); | |||
There was a problem hiding this comment.
just for the record, this I expect is temporary and will change to forTopicIdsOrNames once we include client support for the new RPC versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the OffsetCommit API to support topic ids. From
version 10 of the API, topic ids must be used. Originally, we wanted to
support both using topic ids and topic names from version 10 but it
turns out that it makes everything more complicated. Hence we propose to
only support topic ids from version 10. Clients which only support using
topic names can either lookup the topic ids using the Metadata API or
stay on using an earlier version.
The patch only contains the server side changes and it keeps the version
10 as unstable for now. We will mark the version as stable when the
client side changes are merged in.
Reviewers: Lianet Magrans [email protected], PoAn Yang
[email protected]