KAFKA-19422: Deflake streams_application_upgrade_test #20004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this upgrade test, applications sometimes crash before the upgrade, so it's actually triggering a bug in several older versions (2.x and possibly others). It seems to be a rare race condition that has been happening since 2022. Since we are not going to roll out a patch release for Kafka Streams 2.x, we should just allow applications to crash before the upgrade.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the upgrade test for Kafka Streams to allow for applications crashing on shutdown in older versions. The changes modify verification patterns to accept either "EXCEPTION" or "CLOSED" events rather than only "CLOSED", thereby deflaking the streams application upgrade test.
- Updated wait_for_verification regex patterns in the test for processor nodes.
- Adjusted SSH grep commands to match the new regex pattern.
|
PTAL @aliehsaeedii |
mjsax
reviewed
Jun 21, 2025
| self.wait_for_verification(self.processor2, "SMOKE-TEST-CLIENT-CLOSED", self.processor2.STDOUT_FILE) | ||
| self.wait_for_verification(self.processor3, "SMOKE-TEST-CLIENT-CLOSED", self.processor3.STDOUT_FILE) | ||
| # some older versions crash on shutdown, so we allow crashes here. | ||
| self.wait_for_verification(self.processor1, "SMOKE-TEST-CLIENT-(EXCEPTION|CLOSED)", self.processor1.STDOUT_FILE) |
There was a problem hiding this comment.
Should we add a version check, and apply this new verification only for the older version(s) which are problematic?
Same below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this upgrade test, applications sometimes crash before the upgrade,
so it's actually triggering a bug in several older versions (2.x and
possibly others). It seems to be a rare race condition that has been
happening since 2022. Since we are not going to roll out a patch release
for Kafka Streams 2.x, we should just allow applications to crash before
the upgrade.