MINOR: Invoke share group rebalance sensor. #20006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smjn
added
KIP-932
AndrewJSchofield
requested changes
Jun 20, 2025
| @@ -2575,6 +2576,10 @@ private CoordinatorResult<Map.Entry<ShareGroupHeartbeatResponseData, Optional<In | |||
| records | |||
| ) || initializedAssignmentPending(group); | |||
|
|
|||
| if (bumpGroupEpoch) { | |||
| metrics.record(SHARE_GROUP_REBALANCES_SENSOR_NAME); | |||
There was a problem hiding this comment.
Is there any reason why this metric is not recorded on line 2618, just after the log.info("[GroupId {}] Bumped group epoch...?
There was a problem hiding this comment.
Yes, that would be more appropriate
There was a problem hiding this comment.
Thanks. I'm just aiming to get the different group types to do this stuff in the same way.
|
@AndrewJSchofield Thanks for the review, incorporated comments. |
AndrewJSchofield
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appropriate group id bump position.
(s/rebalance-rate/share-group-rebalance-rate,
s/rebalance-count/share-group-rebalance-count/)
GroupMetadataManagerTestandGroupCoordinatorMetricsTestReviewers: Andrew Schofield [email protected]