Skip to content

Spelling #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025
Merged

Spelling #207

merged 7 commits into from
Jun 16, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 15, 2025

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/container/actions/runs/15662939575/attempts/1
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/container/actions/runs/15662939742/attempts/1#summary-44123289718

@adityaramani
Copy link
Contributor

Thanks for the changes. Looks like you need to sign your commits before we can merge. Can you please setup commit signing and re-push your commits?

jsoref added 7 commits June 16, 2025 07:51
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Jun 16, 2025

@adityaramani done

@jsoref
Copy link
Contributor Author

jsoref commented Jun 16, 2025

✘ Test testCreateExecCommand() recorded an issue at TestCLIExec.swift:36:25: Issue recorded
↳ failed to exec in container .executionFailed("command failed: \u{1B}[33mWarning!\u{1B}[0m Running debug build. Performance may be degraded.\nError: internalError: \"stop failed for one or more containers testCreateExecCommand\"\n")
✘ Test testCreateExecCommand() failed after 85.594 seconds with 1 issue.

...

✘ Test run with 39 tests failed after 505.247 seconds with 1 issue.

why does it say 1 issue when two tests failed? (I'm assuming 39 didn't fail...)

@adityaramani
Copy link
Contributor

I think it was just the one test that failed. There were two log line recorded since one was for the actual test, and other saying that a test group failed.

Re-ran them and looks like it was a flake

@katiewasnothere katiewasnothere merged commit 4a4ad40 into apple:main Jun 16, 2025
3 of 4 checks passed
@jsoref jsoref deleted the spelling branch June 16, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants