Migrate TestRemoveOnUnsupportedKey from test_config.py to config_test.go

Author: MatteoPologruto

internal/integrationtest/config/config_test.go

@@ -519,3 +519,27 @@ func TestRemoveMultipleArguments(t *testing.T) {
 	require.NoError(t, err)
 	requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[]")
 }
+
+func TestRemoveOnUnsupportedKey(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Create a config file
+	_, _, err := cli.Run("config", "init", "--dest-dir", ".")
+	require.NoError(t, err)
+
+	// Verifies default value
+	stdout, _, err := cli.Run("config", "dump", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Query(t, stdout, ".daemon | .port", "\"50051\"")
+
+	// Tries and fails to remove an item
+	_, stderr, err := cli.Run("config", "remove", "daemon.port", "50051")
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "The key 'daemon.port' is not a list of items, can't remove from it.\nMaybe use 'config delete'?")
+
+	// Verifies value is not changed
+	stdout, _, err = cli.Run("config", "dump", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Query(t, stdout, ".daemon | .port", "\"50051\"")
+}

test/test_config.py

@@ -17,31 +17,6 @@
 import yaml
 
 
-def test_remove_on_unsupported_key(run_command):
-    # Create a config file
-    assert run_command(["config", "init", "--dest-dir", "."])
-
-    # Verifies default value
-    result = run_command(["config", "dump", "--format", "json"])
-    assert result.ok
-    settings_json = json.loads(result.stdout)
-    assert "50051" == settings_json["daemon"]["port"]
-
-    # Tries and fails to add a new item
-    result = run_command(["config", "remove", "daemon.port", "50051"])
-    assert result.failed
-    assert (
-        "The key 'daemon.port' is not a list of items, can't remove from it.\nMaybe use 'config delete'?"
-        in result.stderr
-    )
-
-    # Verifies value is not changed
-    result = run_command(["config", "dump", "--format", "json"])
-    assert result.ok
-    settings_json = json.loads(result.stdout)
-    assert "50051" == settings_json["daemon"]["port"]
-
-
 def test_set_slice_with_single_argument(run_command):
     # Create a config file
     assert run_command(["config", "init", "--dest-dir", "."])