Skip to content

Fixing format of the warning, bold changed to __ #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fixing format of the warning, bold changed to __ #1891

merged 1 commit into from
Apr 23, 2024

Conversation

jcarolinares
Copy link
Contributor

What This PR Changes

  • Wisgate update tutorial Fixing format of the warning, bold changed to __

Contribution Guidelines

@jcarolinares jcarolinares requested a review from mcmchris April 23, 2024 15:12
mcmchris
mcmchris approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@mcmchris mcmchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed in a local preview:
image

@jcarolinares
Copy link
Contributor Author

Merging, thank you @mcmchris

@jcarolinares
Copy link
Contributor Author

I will skip cloudfare pages until further notice regarding if they are working again or not. We doubled checked on a local render

@jcarolinares jcarolinares merged commit 3e57550 into main Apr 23, 2024
@jcarolinares jcarolinares deleted the jcarolinares/wisgate-firmware-warning-fix branch April 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmchris mcmchris mcmchris approved these changes

Assignees
No one assigned
Labels
pro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcarolinares @mcmchris