Skip to content

Update repositories.txt #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

affanhanifathtarech
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

A problem was found with your submission https://github.com/affanhanifathtarech/DS3231_RTC

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @affanhanifathtarech
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link

@pejuangsubuhind pejuangsubuhind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its okay

@affanhanifathtarech
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

A problem was found with your submission https://github.com/affanhanifathtarech/DS3231_RTC

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @affanhanifathtarech
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@affanhanifathtarech
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/affanhanifathtarech/DS3231_RTC:

Linting library in DS3231_RTC
INFO: No header file found matching library name (DS3231_RTC.h). Best practices are for primary header filename to match
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

@github-actions github-actions bot merged commit 050ef41 into arduino:main Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/affanhanifathtarech/DS3231_RTC/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants