add support for BSEC2 library features #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstbud
force-pushed
the
fea_bsec2_with_webupdate
branch
from
941602a to
ada8ca0
Compare
This was referenced Mar 30, 2023
|
Memory usage change @ ada8ca0
Click for full report table
Click for full report CSV |
|
@facchinm |
|
Sure, I didn't have the chance to test it yet but we'll surely take a look very soon @sebromero |
aliphys
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Hello @bstbud 👋
Thanks for your contributions. So comments:
- The two newly added examples -
BSECGasScannerClassify.inoandBSECGasScannerCollectData.ino- compile successfully. However, they do not send any data over to the Serial monitor. - The examples use very low level syntax to interface with the sensor. This increases the barrier of entry for users.
- The additional code should be documented, for future records as well as helping users.
cc @facchinm
| if (bsec2.getNewDataFlag()) { | ||
| bsec2.setNewDataFlag(false); | ||
|
|
||
| Serial.println(bsec2.toString()); |
There was a problem hiding this comment.
The bsec2.toString() function does not print anything to the Serial. I've verified that the Serial port is sending data correctly.
There was a problem hiding this comment.
To use the new examples, the new BHI260 FW needs to be updated as well, I agree this should be mentioned in a README or some other documentation. Could you try the examples after updating the BHI260 FW by using the BHYFirmwareUpdate sketch.
There was a problem hiding this comment.
Hi @bstbud ! Is there a way to extract the BHI260 FW version from the binary data? Is so, what's the offset and format?
Arduino_BHY2/examples/BSEC2GasScannerCollectData/BSEC2GasScannerCollectData.ino
Show resolved
Hide resolved
Arduino_BHY2/examples/BSEC2GasScannerCollectData/tools/BSEC2DataLogConverter.py
Show resolved
Hide resolved
Arduino_BHY2/examples/BSEC2GasScannerCollectData/tools/BSEC2DataLogConverter.py
Show resolved
Hide resolved
bstbud
force-pushed
the
fea_bsec2_with_webupdate
branch
from
e5b7a53 to
0cf4a57
Compare
|
Memory usage change @ 0cf4a57
Click for full report table
Click for full report CSV |
bstbud
force-pushed
the
fea_bsec2_with_webupdate
branch
from
0cf4a57 to
8c6d6a6
Compare
|
Memory usage change @ 8c6d6a6
Click for full report table
Click for full report CSV |
|
@aliphys can we push this ? |
|
@akash73 Looking into this PR in this sprint. Will keep you updated |
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add support for BSEC2 gas scanning sensors: sensor id (116) for data collection to be used with BME AI Studio, sensor id(117) for gas type classification
add the API to set board temperature offset relative to ambient air temperature for temperature and relative humidity compensation
add WebBLE parser support for sensor 116 and 117.
Pull request type