fix(logger): caplog working with parent Logger

[amin-farjadi]

Issue number: #6753

Summary

Caplog fixture was not capturing logs made by parent loggers (logger with no child=True arg).

Changes

SupressFilter is not applied to pytest's LogCaptureHanlder.

User experience

Users can now use caplog fixture to test their parent logger's behaviour

def test_parent_logger_with_caplog(caplog, service_name):
    caplog.set_level("INFO")
    logger = Logger(service=service_name)
    logger.info("testing, testing...")

    assert len(caplog.records) == 1
    assert caplog.records[0].message == "testing, testing..."

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change? No

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (a5482c8) to head (a571fa2).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #6847   +/-   ##
========================================
  Coverage    96.21%   96.21%           
========================================
  Files          273      273           
  Lines        12691    12693    +2     
  Branches       946      947    +1     
========================================
+ Hits         12211    12213    +2     
  Misses         375      375           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[leandrodamascena]

Hey @amin-farjadi thanks for sending this PR! I'm thinking that probably make sense I move everything to use caplog and I'll probably do that in a separate PR.

btw, the CI is failing and I'm trying to figure out.

APPROVED.

[amin-farjadi]

@leandrodamascena
I think it would be good to keep some of the stream-based tests. When I was testing around to make my tests pass, my tests were passing but some of the stream-based tests were failing which, was quite useful...

[amin-farjadi]

I will see why pytest is failing

[leandrodamascena]

I will see why pytest is failing

Don't worry, this is about GH runners going crazy with threads. I'll fix it.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud