Skip to content

chore(ecs): add Windows2025 AMI #34901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

Conversation

phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Jul 3, 2025

Issue # (if applicable)

None

Reason for this change

https://aws.amazon.com/about-aws/whats-new/2025/07/aws-availability-ecs-optimized-windows-server-2025-amis/

Description of changes

  • Add Windows 2025 AMI
  • Integ update instance type + image since old ones no longer compatible
Screenshot 2025-07-03 205357

Error of old image on Windows2025

CannotStartContainerError: Error response from daemon: container f21c7ecd0047ff6ab04059523979ab2c16f20efa2a40a8a68d718fa30131f40c encountered an error during hcs::System::Start: failure in a Windows system call: The container operating system does not match the host operating system.

Describe any new or updated permissions being added

Description of how you validated changes

Integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 3, 2025 16:22
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jul 3, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 3, 2025
@phuhung273 phuhung273 force-pushed the ecs-window-2025-ami branch from 739ab7a to b4dad3a Compare July 5, 2025 09:45
@kumsmrit kumsmrit self-assigned this Jul 8, 2025
@kumsmrit
Copy link

Thank you for your contribution.

The ECS API does seem to support Windows Server 2025 as an operating system family: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RuntimePlatform.html. Please consider adding these to runtime-platform.ts and validate if integ test error still occurs.

@kumsmrit kumsmrit added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 10, 2025
@phuhung273
Copy link
Contributor Author

Thanks for taking a look @kumsmrit, I can confirm the same issue as of today on us-east-1
image

Looking at cpuArchitecture param description You can run your Linux tasks on an ARM-based platform by setting the value to ARM64. This option is available for tasks that run on Linux Amazon EC2 instance or Linux containers on Fargate, I also tried to remove it but same error.

Could you help inform ECS team ?

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 10, 2025
@phuhung273
Copy link
Contributor Author

@kumsmrit I can see #34981 already covered runtime-platform.ts

@kumsmrit
Copy link

@kumsmrit I can see #34981 already covered runtime-platform.ts

Thank you for linking the associated PR. I was waiting on getting update from ECS team, but since that change is already merged, approving this current PR for other changes.

kumsmrit
kumsmrit previously approved these changes Jul 18, 2025
Copy link
Contributor

mergify bot commented Jul 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jul 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed kumsmrit’s stale review July 18, 2025 14:28

Pull request has been modified.

@phuhung273
Copy link
Contributor Author

Thanks so much for helping @kumsmrit

Copy link
Contributor

mergify bot commented Jul 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d05b44b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f2f5dae into aws:main Jul 18, 2025
22 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@phuhung273 phuhung273 deleted the ecs-window-2025-ami branch July 18, 2025 14:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants