Skip to content

feat: remove CreateTable and friends #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2023
Merged

feat: remove CreateTable and friends #240

merged 5 commits into from
Jun 23, 2023

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ajewellamz ajewellamz requested a review from a team as a code owner June 17, 2023 18:29
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I feel like I am missing some context.
Have we determined that we do not need to modify Table requests?

@ajewellamz
Copy link
Contributor Author

That is correct. Most customers will want to use the console or CloudFormation to create their tables and indexes, and so patching the API would have a fairly small audience, and we would still need to document how do do it manually.

Given that the workshop was ok without it, it was determined that the best approach was to remove it altogether, rather than to add the java code to enable it.

@ajewellamz ajewellamz merged commit 5072e1e into main Jun 23, 2023
@ajewellamz ajewellamz deleted the retire-create-table branch June 23, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants