Skip to content

feat: Global Parts List #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 2, 2023
Merged

feat: Global Parts List #442

merged 17 commits into from
Oct 2, 2023

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ajewellamz ajewellamz requested a review from a team as a code owner September 22, 2023 18:45
// The fruit beacon allows searching on the encrypted fruit attribute
StandardBeacon fruitBeacon = StandardBeacon.builder()
.name("fruit")
.length(30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a note here about how we decided the length of this beacon.

I could see this ranging from a lightweight

"we have selected 30 as an example, but you should go to https://docs.aws.amazon.com/database-encryption-sdk/latest/devguide/choosing-beacon-length.html when creating your beacons"

to a more in-depth consideration ala other examples

"there are N possible fruits, do the math on https://docs.aws.amazon.com/database-encryption-sdk/latest/devguide/choosing-beacon-length.html and we get 30" (or a different number)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

put an item with the beacon, and query against that beacon.
This example follows a use case of a database that stores food information.
This is an extension of the "BasicSearchableEncryptionExample" in this directory
and uses the same table schema.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have docs for this feature?
If so, I think we should add a link to them here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs yet. There's a Quip doc, but nothing customer accessible. There are doc tickets in the queue.

.build();
standardBeaconList.add(dessertBeacon);

// 3. Configure the Keystore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be step 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Everything from 3-15 renumbered.

ajewellamz and others added 7 commits September 27, 2023 13:29
…re/amazon/cryptography/examples/searchableencryption/BeaconStylesSearchableEncryptionExample.java

Co-authored-by: Lucas McDonald <[email protected]>
…re/amazon/cryptography/examples/searchableencryption/BeaconStylesSearchableEncryptionExample.java

Co-authored-by: Lucas McDonald <[email protected]>
…re/amazon/cryptography/examples/searchableencryption/BeaconStylesSearchableEncryptionExample.java

Co-authored-by: Lucas McDonald <[email protected]>
…re/amazon/cryptography/examples/searchableencryption/BeaconStylesSearchableEncryptionExample.java

Co-authored-by: Lucas McDonald <[email protected]>
…re/amazon/cryptography/examples/searchableencryption/BeaconStylesSearchableEncryptionExample.java

Co-authored-by: Lucas McDonald <[email protected]>
…re/amazon/cryptography/examples/searchableencryption/BeaconStylesSearchableEncryptionExample.java

Co-authored-by: Lucas McDonald <[email protected]>
&& encrypted.Success?
&& ret.value.base.name == beacon.name
&& (|encrypted.value| == 0 ==> ret.value.base.beaconName == beacon.name)
&& (|encrypted.value| != 0 ==> ret.value.base.beaconName == BeaconPrefix + beacon.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this aligns with the duvet notation above.
I assume that BeaconPrefix ==> aws_dbe_b_?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, BeaconPrefix is "aws_dbe_b_".
The ensures says "no encrypted parts implies name is unprefixed"
The duvet comment says "name MUST be unprefixed", with the lost context of "for a signed beacon".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHHHH, yes, I see it. the section is #signed-beacons.
Yes, this is why I like only having direct objects in the names. Note to self.

Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajewellamz ajewellamz merged commit fcc7c6e into main Oct 2, 2023
@ajewellamz ajewellamz deleted the global-parts branch October 2, 2023 21:36
ajewellamz added a commit that referenced this pull request Nov 14, 2023
* feat: Global Parts List
* add BeaconStylesSearchableEncryptionExample.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants