Skip to content

feat: dont use internal, because it is reserved in dotnet #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ajewellamz ajewellamz requested a review from a team as a code owner September 28, 2023 14:49
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not idiomatic Java.
Let's talk to Jose and Val about this.
We may need to restructure this repo like Jose did for .NET.

@ajewellamz ajewellamz merged commit fa2b610 into main Sep 28, 2023
@ajewellamz ajewellamz deleted the internal-is-reserved branch September 28, 2023 18:36
@seebees
Copy link
Contributor

seebees commented Sep 28, 2023

Late but LGTM

ajewellamz added a commit that referenced this pull request Nov 14, 2023
* feat: dont use internal, because it is reserved in dotnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants