feat: repair dependencies in item encryptor #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
reviewed
Sep 29, 2023
...DynamoDbEncryptionTransforms/Model/AwsCryptographyDbEncryptionSdkDynamoDbTransformsTypes.dfy
Show resolved
Hide resolved
Comment on lines
+102
to
+106
| @aws.polymorph#reference(service: aws.cryptography.dbEncryptionSdk.structuredEncryption#StructuredEncryption) | ||
| structure StructuredEncryptionReference {} | ||
|
|
||
| @aws.polymorph#reference(service: aws.cryptography.materialProviders#AwsCryptographicMaterialProviders) | ||
| structure AwsCryptographicMaterialProvidersReference {} |
There was a problem hiding this comment.
Issue: We SHOULD NOT need these.
I know you slacked me, stating this solved an issue.
I would like to understand why/how this solved that issue.
There was a problem hiding this comment.
Resolving this and will Approve the PR.
We SHOULD create a GHI against Smithy-Dafny for this,
describing the problem (dependency error discovery when generating Dafny)
the solution (use LocalService's dependencies field for error and include discovery)
and the work around (add references to the local model).
texastony
approved these changes
Sep 29, 2023
ajewellamz
added a commit
that referenced
this pull request
Nov 14, 2023
* feat: repair dependencies in item encryptor et al
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.