Skip to content

Add SDK v1 transformers #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Add SDK v1 transformers #195

merged 1 commit into from
Dec 9, 2020

Conversation

carlzogh
Copy link
Contributor

@carlzogh carlzogh commented Dec 8, 2020

Issue #, if available: #182

Description of changes:

  • Added SDK v1 transformers (under transformers.v1 package)
  • Moved v2 transformers to transformers.v2 package
  • Bumped transformer lib to 3.0.0

As the scope of these two SDK dependencies is provided, users have full control over which to include and use without having to include the other version. I've also opted to separate into different packages to keep a cleaner separation between v1 and v2 models and test cases.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@zsombor-balogh zsombor-balogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@stefanbotez stefanbotez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlzogh carlzogh merged commit 3e71a17 into aws:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants