Skip to content

Fix incorrect signature with SetPreservePathSeparators(true) caused by stale m_pathHasTrailingSlash #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shurarama
Copy link

@shurarama shurarama commented Jul 18, 2025

Issue #3484

This PR fixes an issue where pathless requests (e.g., STS or Athena) fail signature validation when Aws::Http::SetPreservePathSeparators(true) is enabled.

The root cause lies in the handling of URI::SetPath(...):

  • When an empty path is parsed, the SDK assigns / via SetPath("/"), which sets m_pathHasTrailingSlash = true.
  • Later, the SDK internally re-applies the path via uri.SetPath(uri.GetURLEncodedPathRFC3986());, assuming it is idempotent.
  • But in AddPathSegments(...), this flag interferes with leading empty segment removal logic:
if (s_preservePathSeparators && m_pathSegments.empty()
    && !split.empty() && split.front().empty()
    && !m_pathHasTrailingSlash)
{
    split.erase(split.begin());
}

We reset m_pathHasTrailingSlash to false in URI::SetPath() before calling AddPathSegments(...), ensuring consistent re-parsing.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR would require a ReadMe/Wiki update.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR is a breaking (APIs have been changed) change.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant