Fix incorrect signature with SetPreservePathSeparators(true)
caused by stale m_pathHasTrailingSlash
#3483
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3484
This PR fixes an issue where pathless requests (e.g., STS or Athena) fail signature validation when
Aws::Http::SetPreservePathSeparators(true)
is enabled.The root cause lies in the handling of
URI::SetPath(...)
:/
viaSetPath("/")
, which setsm_pathHasTrailingSlash = true
.uri.SetPath(uri.GetURLEncodedPathRFC3986());
, assuming it is idempotent.AddPathSegments(...)
, this flag interferes with leading empty segment removal logic:We reset m_pathHasTrailingSlash to false in URI::SetPath() before calling AddPathSegments(...), ensuring consistent re-parsing.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.