Skip to content

chore(token-providers): add feature ID 'BEARER_SERVICE_ENV_VARS' #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 30, 2025

Issue

Internal JS-5860

Description

Adds feature ID 'BEARER_SERVICE_ENV_VARS'

Testing

Unit tests in CI

In internal test setup, the feature ID 3 is populated with token is set

$ NODE_DEBUG=http node test.mjs 2>&1 | grep "'user-agent'"
    'user-agent': 'aws-sdk-js/3.840.0 ua/2.1 os/darwin#24.5.0 lang/js md/nodejs#22.16.0 api/bedrock#3.840.0 m/N,E,3',

The feature ID 3 is not populated when token is not set. It instead populates feature IDs w and v for credentials.

$ NODE_DEBUG=http node test.mjs 2>&1 | grep "'user-agent'"
    'user-agent': 'aws-sdk-js/3.840.0 ua/2.1 os/darwin#24.5.0 lang/js md/nodejs#22.16.0 api/bedrock#3.840.0 m/N,E,w,v',

Additional context

PR to set credential attribution for reference #6546


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review June 30, 2025 18:04
@trivikr trivikr requested a review from a team as a code owner June 30, 2025 18:04
@trivikr trivikr merged commit 1b200b5 into main Jun 30, 2025
8 checks passed
@trivikr trivikr deleted the set-token-feature branch June 30, 2025 18:23
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants