Skip to content

remove credentials if blank, causing the SDK to use ec2 role #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2015
Merged

remove credentials if blank, causing the SDK to use ec2 role #84

merged 5 commits into from
Sep 18, 2015

Conversation

chuck014
Copy link
Contributor

This allows the AWS-SDK to connect if run on an ec2 instance without a key/secret needing to be provided.

@GrahamCampbell
Copy link
Contributor

Every line has cs issues. :/

@jeskew
Copy link
Contributor

jeskew commented Sep 15, 2015

Couldn't you just remove the credentials array from the published config file?

@GrahamCampbell
Copy link
Contributor

Yeh, probably. Not sure why this PR is needed?

@chuck014
Copy link
Contributor Author

Did a vendor:publish edited the config/aws.php file removing the credentials array.
It errors asking for a key.

If you remove it as in the PR it lets the SDK use ec2 instance credentials

@jeskew
Copy link
Contributor

jeskew commented Sep 15, 2015

Would it be better to just remove the offending lines from the packaged config file?

@jeremeamia
Copy link
Contributor

Yeah, I'd rather see the change in the config.

@jeskew
Copy link
Contributor

jeskew commented Sep 15, 2015

@chuck014 That test failure is due to a language feature used in the InstanceProfileProvider not being supported by HHVM. You can flag HHVM as an allowable failure in the .travis.yml file; take a look at how that's done in the SDK package for an example.

jeskew added a commit that referenced this pull request Sep 18, 2015
remove credentials if blank, causing the SDK to use ec2 role
@jeskew jeskew merged commit 47d805e into aws:master Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants