Skip to content

Limit sagemaker sdk v2 version dependency #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

FrancisLfg
Copy link
Contributor

This sdk is not working with sagemaker sdk v2, when running tests lot of errors are displayed (like the following) :

______________________________________________________________________________________________ ERROR at setup of test_model_step_creation ______________________________________________________________________________________________

    @pytest.fixture
    def pca_model():
        model_data = 's3://sagemaker/models/pca.tar.gz'
        return Model(
            model_data=model_data,
            image=PCA_IMAGE,
            role=EXECUTION_ROLE,
>           name='pca-model'
        )
E       TypeError: __init__() got an unexpected keyword argument 'image'

tests/unit/test_sagemaker_steps.py:121: TypeError

So while waiting for sagemaker v2 compatibility, what about limiting version so that tests can succeed just by following README steps (for now it is not the case depending on sagemaker version) ?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: StepFunctionsPythonSDK-integtests
  • Commit ID: 10202d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shunjd shunjd merged commit 0b5e6f1 into aws:master Aug 10, 2020
@shunjd
Copy link
Contributor

shunjd commented Aug 10, 2020

Thank you @FrancisLfg for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants