Skip to content

Expose TuningStep #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2020
Merged

Expose TuningStep #77

merged 3 commits into from
Sep 22, 2020

Conversation

mriccia
Copy link
Contributor

@mriccia mriccia commented Aug 19, 2020

The TuningStep Class is not exposed, making it not possible to import like other steps.
e.g. from stepfunctions.steps import TuningStep

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mriccia
Expose TuningStep
b038ecb 
The TuningStep Class is not exposed, making it not possible to import like other steps.
e.g. `from stepfunctions.steps import TuningStep`
@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: StepFunctionsPythonSDK-integtests
  • Commit ID: b038ecb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mriccia mriccia changed the base branch from master to surivaib/release-1.0.0.7 August 19, 2020 15:42
@mriccia
Copy link
Contributor Author

mriccia commented Aug 19, 2020

Changed base branch as this should be fix ASAP and published.
Currently it is not possible to use TuningStep with this library, which will lead to poor customer experience

@vaib-amz
Copy link
Contributor

vaib-amz commented Sep 4, 2020

Thanks for this fix @mriccia. Regarding the base branch, we can still have it be part of master and release this with the next release of the SDK. v1.0.0.7 is already released.

@mriccia mriccia changed the base branch from surivaib/release-1.0.0.7 to master September 11, 2020 17:38
@mriccia
Copy link
Contributor Author

mriccia commented Sep 11, 2020

thanks @vaib-amz I have changed the base branch to Master, please take a look.

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: StepFunctionsPythonSDK-integtests
  • Commit ID: dba616b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vaib-amz vaib-amz self-requested a review September 22, 2020 00:16
@vaib-amz vaib-amz merged commit bc72e3f into aws:master Sep 22, 2020
@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: StepFunctionsPythonSDK-integtests
  • Commit ID: c1f4485
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mriccia mriccia deleted the patch-1 branch January 5, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wong-a wong-a wong-a approved these changes

@vaib-amz vaib-amz vaib-amz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mriccia @StepFunctions-Bot @vaib-amz @wong-a