Skip to content

Enforce Python 3.8 usage in Dockerfile #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Enforce Python 3.8 usage in Dockerfile #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac2685
Enforce Python 3.8 on Dockerfile
michaelnchin Apr 8, 2023
8307cdb
update changelog
michaelnchin Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Starting with v1.31.6, this file will contain a record of major features and upd
- Fixed Dockerfile builds breaking with AL2023 ([Link to PR](https://github.com/aws/graph-notebook/pull/466))
- Fixed `--store-to` option for several magics ([Link to PR](https://github.com/aws/graph-notebook/pull/463))
- Fixed broken documentation links in Neptune ML notebooks ([PR #1](https://github.com/aws/graph-notebook/pull/467)) ([PR #2](https://github.com/aws/graph-notebook/pull/468))
- Deprecated Python 3.7 support ([PR #1](https://github.com/aws/graph-notebook/pull/453)) ([PR #2](https://github.com/aws/graph-notebook/pull/473))

## Release 3.7.3 (March 14, 2023)
- Fixed detailed mode output for graph summary requests ([Link to PR](https://github.com/aws/graph-notebook/pull/461))
Expand Down
13 changes: 9 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ENV pipargs=""
ENV WORKING_DIR="/root"
ENV NOTEBOOK_DIR="${WORKING_DIR}/notebooks"
ENV EXAMPLE_NOTEBOOK_DIR="${NOTEBOOK_DIR}/Example Notebooks"
ENV NODE_VERSION=12.x
ENV NODE_VERSION=14.x
ENV GRAPH_NOTEBOOK_AUTH_MODE="DEFAULT"
ENV GRAPH_NOTEBOOK_HOST="neptune.cluster-XXXXXXXXXXXX.us-east-1.neptune.amazonaws.com"
ENV GRAPH_NOTEBOOK_PROXY_PORT="8192"
Expand All @@ -36,20 +36,25 @@ RUN mkdir -p "${WORKING_DIR}" && \
mkdir -p "${EXAMPLE_NOTEBOOK_DIR}" && \
# Yum Update and install dependencies
yum update -y && \
yum install tar gzip git -y && \
yum install tar gzip git amazon-linux-extras which -y && \
# Install NPM/Node
curl --silent --location https://rpm.nodesource.com/setup_${NODE_VERSION} | bash - && \
yum install nodejs -y && \
npm install -g opencollective && \
yum install python3 -y && \
# Install Python 3.8
amazon-linux-extras install python3.8 -y && \
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \
echo 'Using python version:' && \
python3 --version && \
python3 -m ensurepip --upgrade && \
python3 -m venv /tmp/venv && \
source /tmp/venv/bin/activate && \
cd "${WORKING_DIR}" && \
# Clone the repo and install python dependencies
git clone https://github.com/aws/graph-notebook && \
cd "${WORKING_DIR}/graph-notebook" && \
pip3 install --upgrade pip setuptools wheel twine && \
pip3 install --upgrade pip setuptools wheel && \
pip3 install twine==3.7.1 && \
pip3 install -r requirements.txt && \
pip3 install "jupyterlab>=3" && \
# Build the package
Expand Down