Skip to content

fixed library target for nbclassic nbextension for graph_notebook_widget #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

adityaramesh12
Copy link
Contributor

Issue #, if available: Issue #738

Description of changes:
This PR addresses issues with extension loading in Jupyter Notebook Classic (NBClassic) environments. The changes modify the webpack configuration to ensure proper module definition and loading.

Key Changes:

  1. Modified the first nbextension output:

    • Changed libraryTarget from "amd" to "var"
    • This ensures the extension is properly exposed as a global variable, which is necessary for NBClassic's initial extension loading process
  2. Adjusted the second nbextension output:

    • Removed the library name for the AMD module (set to undefined)
    • This allows for proper AMD module definition without potential namespace conflicts

These changes align our extension with the expected module loading patterns in Jupyter notebooks, addressing potential issues where the extension might fail to load or initialize properly in certain environments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's make sure to include a changelog entry.

@adityaramesh12
Copy link
Contributor Author

Thanks @michaelnchin ! I'll add it to the changelog in a separate PR for 5.0.1 changes/

@adityaramesh12 adityaramesh12 merged commit 69b4325 into main May 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants