fixed library target for nbclassic nbextension for graph_notebook_widget #739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Issue #738
Description of changes:
This PR addresses issues with extension loading in Jupyter Notebook Classic (NBClassic) environments. The changes modify the webpack configuration to ensure proper module definition and loading.
Key Changes:
Modified the first nbextension output:
libraryTarget
from "amd" to "var"Adjusted the second nbextension output:
library
name for the AMD module (set toundefined
)These changes align our extension with the expected module loading patterns in Jupyter notebooks, addressing potential issues where the extension might fail to load or initialize properly in certain environments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.